netdev - Re: [PATCH net-next] net: samsung: sxgbe: Make sxgbe_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 May 2023 12:51:24 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Byungho An <bh74.an@...sung.com>, netdev@...r.kernel.org,
	Eric Dumazet <edumazet@...gle.com>, kernel@...gutronix.de,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] net: samsung: sxgbe: Make sxgbe_drv_remove()
 return void

On Thu, May 11, 2023 at 12:45:09PM +0200, Uwe Kleine-König wrote:
> On Thu, May 11, 2023 at 12:28:54PM +0200, Simon Horman wrote:
> > On Thu, May 11, 2023 at 12:17:40PM +0200, Simon Horman wrote:
> > > On Wed, May 10, 2023 at 10:02:47PM +0200, Uwe Kleine-König wrote:
> > > > sxgbe_drv_remove() returned zero unconditionally, so it can be converted
> > > > to return void without losing anything. The upside is that it becomes
> > > > more obvious in its callers that there is no error to handle.
> > > > 
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > 
> > > Reviewed-by: Simon Horman <simon.horman@...igine.com>
> > 
> > Sorry, minor nit.
> > Perhaps the subject prefix should be 'net: sxgbe: ', for consistency.
> > Or 'sxgbe: ' because the 'net: ' part is largely meaningless.
> 
> I'd not drop "net:". Looking at the output of
> 
> 	git log --format=%s next/master -- drivers/net/ethernet/samsung/sxgbe/ | sed 's/:[^:]*$//' | sort | uniq -c | sort -n
> 
> the clear winner is "net: sxgbe: ".
> 
> If and when I will resend this patch, I'll adapt accordingly. If it's
> taken as is (or the committer adapts the subject line) that's fine for
> me, too.

Thanks, that's good for me on all counts.