lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZFzVMHCTMeiTB4T1@pidgin.makrotopia.org> Date: Thu, 11 May 2023 13:44:48 +0200 From: Daniel Golle <daniel@...rotopia.org> To: Heiner Kallweit <hkallweit1@...il.com> Cc: netdev@...r.kernel.org, linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com> Subject: Re: [PATCH net-next 0/8] Improvements for RealTek 2.5G Ethernet PHYs On Thu, May 11, 2023 at 07:29:21AM +0200, Heiner Kallweit wrote: > On 11.05.2023 00:53, Daniel Golle wrote: > > Improve support for RealTek 2.5G Ethernet PHYs (RTL822x series). > > The PHYs can operate with Clause-22 and Clause-45 MDIO. > > [...] > > Has this series been tested with RTL8125A/B to ensure that the internal > PHY use case still works? The series has been present in OpenWrt for a while now and initially contained a bug which broke the RTL8221 PCIe RealTek NICs. It has since been resolved and re-tested, and it seems all fine: https://github.com/openwrt/openwrt/commit/998b9731577dedc7747dcfa412e4543dabaaa131#r110201620 I assume that quite some OpenWrt users may use RTL8125B PCIe NICs, but I have asked in the OpenWrt forum for testing results including this series: https://forum.openwrt.org/t/nanopi-r6s-kernel-6-1-intergration/154677/3?u=daniel As the r8169 driver is not using phylink and uses C22 to connect to the PHY the main difference which will affect these devices is that genphy_soft_reset will be called as a result of r8169_hw_phy_config->phy_init_hw->(phydrv).soft_reset Also note the r8169 driver always sets the interface mode to either PHY_INTERFACE_MODE_GMII or PHY_INTERFACE_MODE_MII in r8169_phy_connect() before calling phy_connect_direct(). While this is certainly not technically correct for the 2.5G NICs in the strict sense, it does have the desired effect that the newly introduced function rtl8221b_config_init() just returns without making any changes.
Powered by blists - more mailing lists