netdev - Re: [PATCH net-next v4 2/7] net: wangxun: libwx add rx offload functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06898ce3-3995-2e83-3b2b-97f92fa46d7c@huawei.com>
Date: Thu, 11 May 2023 19:48:30 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
CC: <netdev@...r.kernel.org>, <jiawenwu@...stnetic.com>
Subject: Re: [PATCH net-next v4 2/7] net: wangxun: libwx add rx offload
 functions

On 2023/5/11 16:34, mengyuanlou@...-swift.com wrote:
>>> @@ -321,8 +321,31 @@
>>
>> ...
>>
>>> +
>>> +static inline struct wx_dec_ptype wx_decode_ptype(const u8 ptype)
>>
>> If the above is only used in one .c file, maybe it does not need
>> to be in the .h file?
> 
> If I put it to .c file which use it, when compiling the other .c files will say
> "warning: ‘wx_ptype_lookup’ defined but not used”.

Is 'wx_ptype_lookup' used in other .c file? if not, why not move
it to .c file too?

>>
>>> +{
>>> + return wx_ptype_lookup[ptype];
>>> +}
>>> +