lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZFzncPmqH1C5HAyf@kernel.org> Date: Thu, 11 May 2023 15:02:40 +0200 From: Simon Horman <horms@...nel.org> To: Horatiu Vultur <horatiu.vultur@...rochip.com> Cc: Shenwei Wang <shenwei.wang@....com>, Wei Fang <wei.fang@....com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Clark Wang <xiaoning.wang@....com>, NXP Linux Team <linux-imx@....com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Alexander Lobakin <alexandr.lobakin@...el.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, imx@...ts.linux.dev Subject: Re: [PATCH v2 net 1/1] net: fec: using the standard return codes when xdp xmit errors On Thu, May 11, 2023 at 09:24:52AM +0200, Horatiu Vultur wrote: > The 05/10/2023 15:05, Shenwei Wang wrote: > > > > This patch standardizes the inconsistent return values for unsuccessful > > XDP transmits by using standardized error codes (-EBUSY or -ENOMEM). > > Shouldn't this patch target net-next instead of net? As Simon suggested > here [1], or maybe is just me who misunderstood that part. > Also it is nice to CC people who comment at your previous patches in all > the next versions. > > Just a small thing, if there is only 1 patch in the series, you don't > need to add 1/1 in the subject. > > [1] https://lore.kernel.org/netdev/20230509193845.1090040-1-shenwei.wang@nxp.com/T/#m4b6b21c75512391496294fc78db2fbdf687f1381 > > > > > Fixes: 26312c685ae0 ("net: fec: correct the counting of XDP sent frames") Hi Shenwei, I agree with Horatiu. Also, this is not a fix. So it should not have a Fixes tag. After waiting for further review please send a v3 with these updates. pw-bot: cr
Powered by blists - more mailing lists