netdev - Re: [PATCH net] sfc: disable RXFCS and RXALL features by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFzuud+3c1Le+c79@corigine.com>
Date: Thu, 11 May 2023 15:33:45 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>
Cc: netdev@...r.kernel.org, linux-net-drivers@....com, davem@...emloft.net,
	kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
	ecree.xilinx@...il.com, habetsm.xilinx@...il.com
Subject: Re: [PATCH net] sfc: disable RXFCS and RXALL features by default

On Thu, May 11, 2023 at 10:43:33AM +0100, Pieter Jansen van Vuuren wrote:
> By default we would not want RXFCS and RXALL features enabled as they are
> mainly intended for debugging purposes. This does not stop users from
> enabling them later on as needed.
> 
> Fixes: 8e57daf70671 ("sfc_ef100: RX path for EF100")
> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>
> Co-developed-by: Edward Cree <ecree.xilinx@...il.com>
> Signed-off-by: Edward Cree <ecree.xilinx@...il.com>
> Reviewed-by: Martin Habets <habetsm.xilinx@...il.com>

Thanks Pieter,

looks good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>