lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230511085453.25ef33fc@hermes.local> Date: Thu, 11 May 2023 08:54:53 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: Yang Li <yang.lee@...ux.alibaba.com> Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com> Subject: Re: [PATCH] ipvlan: Remove NULL check before dev_{put, hold} On Thu, 11 May 2023 15:21:19 +0800 Yang Li <yang.lee@...ux.alibaba.com> wrote: > The call netdev_{put, hold} of dev_{put, hold} will check NULL, > so there is no need to check before using dev_{put, hold}, > remove it to silence the warning: > > ./drivers/net/ipvlan/ipvlan_core.c:559:3-11: WARNING: NULL check before dev_{put, hold} functions is not needed. > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4930 > Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com> Maybe add new coccinelle script for this? scripts/free/dev_hold.cocci?
Powered by blists - more mailing lists