netdev - RE: [RFC PATCH v7 1/8] dpll: spec: Add Netlink spec in YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB4657F2BD5767B66A0B18AB009B749@DM6PR11MB4657.namprd11.prod.outlook.com>
Date: Thu, 11 May 2023 20:54:53 +0000
From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Jiri Pirko <jiri@...nulli.us>, Vadim Fedorenko <vadfed@...a.com>, Jonathan
 Lemon <jonathan.lemon@...il.com>, Paolo Abeni <pabeni@...hat.com>, "Olech,
 Milena" <milena.olech@...el.com>, "Michalik, Michal"
	<michal.michalik@...el.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, poros <poros@...hat.com>, mschmidt
	<mschmidt@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>, Vadim Fedorenko
	<vadim.fedorenko@...ux.dev>
Subject: RE: [RFC PATCH v7 1/8] dpll: spec: Add Netlink spec in YAML

>From: Jakub Kicinski <kuba@...nel.org>
>Sent: Thursday, May 11, 2023 5:27 PM
>
>On Thu, 11 May 2023 07:38:04 +0000 Kubalewski, Arkadiusz wrote:
>> >>+  -
>> >>+    type: enum
>> >>+    name: event
>> >>+    doc: events of dpll generic netlink family
>> >>+    entries:
>> >>+      -
>> >>+        name: unspec
>> >>+        doc: invalid event type
>> >>+      -
>> >>+        name: device-create
>> >>+        doc: dpll device created
>> >>+      -
>> >>+        name: device-delete
>> >>+        doc: dpll device deleted
>> >>+      -
>> >>+        name: device-change
>> >
>> >Please have a separate create/delete/change values for pins.
>> >
>>
>> Makes sense, but details, pin creation doesn't occur from uAPI perspective,
>> as the pins itself are not visible to the user. They are visible after they
>> are registered with a device, thus we would have to do something like:
>> - pin-register
>> - pin-unregister
>> - pin-change
>>
>> Does it make sense?
>
>I missed this, notifications should be declared under operations.
>
>Please look at netdev.yaml for an example.
>
>I thought about implementing this model where events are separate
>explicitly but I think it's an unnecessary complication.

Ok, will do.

Thank you!
Arkadiusz