netdev - Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC1cPGxxOhmQS6J9tDCSaaaMEAgpCVRv2XpndyNnyEfvUKcQoA@mail.gmail.com>
Date: Fri, 12 May 2023 09:03:31 -0400
From: Richard Fontana <rfontana@...hat.com>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux SPDX Licenses <linux-spdx@...r.kernel.org>, 
	Linux DRI Development <dri-devel@...ts.freedesktop.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Networking <netdev@...r.kernel.org>, 
	Linux ARM <linux-arm-kernel@...ts.infradead.org>, 
	Linux Staging Drivers <linux-staging@...ts.linux.dev>, 
	Linux Watchdog Devices <linux-watchdog@...r.kernel.org>, 
	Linux Kernel Actions <linux-actions@...ts.infradead.org>, 
	Diederik de Haas <didi.debian@...ow.org>, Kate Stewart <kstewart@...uxfoundation.org>, 
	Philippe Ombredanne <pombredanne@...b.com>, Thomas Gleixner <tglx@...utronix.de>, 
	David Airlie <airlied@...hat.com>, Karsten Keil <isdn@...ux-pingi.de>, 
	Jay Vosburgh <j.vosburgh@...il.com>, Andy Gospodarek <andy@...yhouse.net>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Sam Creasey <sammy@...my.net>, 
	Dominik Brodowski <linux@...inikbrodowski.net>, Daniel Mack <daniel@...que.org>, 
	Haojian Zhuang <haojian.zhuang@...il.com>, Robert Jarzmik <robert.jarzmik@...e.fr>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Wim Van Sebroeck <wim@...ux-watchdog.org>, 
	Guenter Roeck <linux@...ck-us.net>, Jan Kara <jack@...e.com>, Andreas Färber <afaerber@...e.de>, 
	Manivannan Sadhasivam <mani@...nel.org>, "David A . Hinds" <dahinds@...rs.sourceforge.net>, 
	Donald Becker <becker@...ld.com>, Peter De Schrijver <p2@...d.be>, Topi Kanerva <topi@...anna.oulu.fi>, 
	Alain Malek <Alain.Malek@...ogen.com>, Bruce Abbott <bhabbott@...b.co.nz>, 
	Alan Cox <alan@...ux.intel.com>, Greg Ungerer <gerg@...ux-m68k.org>, 
	Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate
 with SPDX identifier

On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya <bagasdotme@...il.com> wrote:
>
> Replace GPL boilerplate notice on remaining files with appropriate SPDX
> tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+.

> diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c
> index 6a0a2039600a0a..ea3488e81c5f3c 100644
> --- a/drivers/net/ethernet/8390/ne2k-pci.c
> +++ b/drivers/net/ethernet/8390/ne2k-pci.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-1.0+
>  /* A Linux device driver for PCI NE2000 clones.
>   *
>   * Authors and other copyright holders:
> @@ -6,13 +7,6 @@
>   * Copyright 1993 assigned to the United States Government as represented
>   * by the Director, National Security Agency.
>   *
> - * This software may be used and distributed according to the terms of
> - * the GNU General Public License (GPL), incorporated herein by reference.
> - * Drivers based on or derived from this code fall under the GPL and must
> - * retain the authorship, copyright and license notice.  This file is not
> - * a complete program and may only be used when the entire operating
> - * system is licensed under the GPL.

I don't think you should delete those last two sentences.

"Drivers based on or derived from this code fall under the GPL and must
retain the authorship, copyright and license notice."

The notice has:

 * Authors and other copyright holders:
 * 1992-2000 by Donald Becker, NE2000 core and various modifications.
 * 1995-1998 by Paul Gortmaker, core modifications and PCI support.
 * Copyright 1993 assigned to the United States Government as represented
 * by the Director, National Security Agency.

Nothing in the GPL requires retention of "authorship", as some other
licenses do (you can argue that GPLv2 conflates authorship with
copyright ownership, but this sentence seems to distinguish
"authorship" from "copyright" as does the listing of authors). There
is (arguably) a tradition of treating extra author attribution
requirements as legitimate, but if you view them as extra requirements
you can't, or shouldn't, just remove them arbitrarily.

Then there's this:

"This file is not a complete program and may only be used when the
entire operating system is licensed under the GPL."

Whether or not that's a correct statement of GPL interpretation
(perhaps it depends on the meaning of "entire operating system"), it's
significant enough as a nonstandard interpretive comment that I think
you should probably not remove it.

Richard