netdev - Re: [PATCH v2 net-next 3/4] sfc: support TC decap rules matching on enc_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03258f61-8ed5-d99a-3e9f-9e162f038691@gmail.com>
Date: Fri, 12 May 2023 15:27:47 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Simon Horman <simon.horman@...igine.com>, edward.cree@....com
Cc: linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org,
 pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org,
 habetsm.xilinx@...il.com
Subject: Re: [PATCH v2 net-next 3/4] sfc: support TC decap rules matching on
 enc_ip_tos

On 12/05/2023 10:51, Simon Horman wrote:
> On Thu, May 11, 2023 at 08:47:30PM +0100, edward.cree@....com wrote:
>>  	if (old) {
>>  		/* don't need our new entry */
>>  		kfree(encap);
> 
> Hi Ed,
> 
> encap is freed here.
> 
...
>> +			if (em_type != EFX_TC_EM_PSEUDO_MASK) {
>> +				NL_SET_ERR_MSG_FMT_MOD(extack,
>> +						       "%s encap match conflicts with existing pseudo(MASK) entry",
>> +						       encap->type ? "Pseudo" : "Direct");
> 
> But dereferenced here.
> 
...
>> +			NL_SET_ERR_MSG_FMT_MOD(extack,
>> +					       "%s encap match conflicts with existing pseudo(%d) entry",
>> +					       encap->type ? "Pseudo" : "Direct",
> 
> And here.

Good catch, thanks.  We should use em_type instead.
Dave already applied so I'll send a follow-up fix shortly.