netdev - Re: [PATCH v2 09/10] udf: Replace license notice with SPDX identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22b3e6c7-895c-c972-bc3f-9390b9b7fb08@gmail.com>
Date: Sat, 13 May 2023 16:31:09 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Richard Fontana <rfontana@...hat.com>
Cc: Linux SPDX Licenses <linux-spdx@...r.kernel.org>,
 Linux DRI Development <dri-devel@...ts.freedesktop.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Networking <netdev@...r.kernel.org>,
 Linux ARM <linux-arm-kernel@...ts.infradead.org>,
 Linux Staging Drivers <linux-staging@...ts.linux.dev>,
 Linux Watchdog Devices <linux-watchdog@...r.kernel.org>,
 Linux Kernel Actions <linux-actions@...ts.infradead.org>,
 Diederik de Haas <didi.debian@...ow.org>,
 Kate Stewart <kstewart@...uxfoundation.org>,
 Philippe Ombredanne <pombredanne@...b.com>,
 Thomas Gleixner <tglx@...utronix.de>, David Airlie <airlied@...hat.com>,
 Karsten Keil <isdn@...ux-pingi.de>, Jay Vosburgh <j.vosburgh@...il.com>,
 Andy Gospodarek <andy@...yhouse.net>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Sam Creasey <sammy@...my.net>, Dominik Brodowski
 <linux@...inikbrodowski.net>, Daniel Mack <daniel@...que.org>,
 Haojian Zhuang <haojian.zhuang@...il.com>,
 Robert Jarzmik <robert.jarzmik@...e.fr>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck
 <linux@...ck-us.net>, Jan Kara <jack@...e.com>,
 Andreas Färber <afaerber@...e.de>,
 Manivannan Sadhasivam <mani@...nel.org>, Pali Rohár
 <pali@...nel.org>, Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH v2 09/10] udf: Replace license notice with SPDX identifier

On 5/12/23 20:21, Richard Fontana wrote:
> On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya <bagasdotme@...il.com> wrote:
> 
>> diff --git a/fs/udf/ecma_167.h b/fs/udf/ecma_167.h
>> index de17a97e866742..b2b5bca45758df 100644
>> --- a/fs/udf/ecma_167.h
>> +++ b/fs/udf/ecma_167.h
>> @@ -1,3 +1,4 @@
>> +/* SPDX-License-Identifier: BSD-2-Clause OR GPL-1.0+ */
>>  /*
>>   * ecma_167.h
>>   *
>> @@ -8,29 +9,6 @@
>>   * Copyright (c) 2017-2019  Pali Rohár <pali@...nel.org>
>>   * All rights reserved.
>>   *
>> - * Redistribution and use in source and binary forms, with or without
>> - * modification, are permitted provided that the following conditions
>> - * are met:
>> - * 1. Redistributions of source code must retain the above copyright
>> - *    notice, this list of conditions, and the following disclaimer,
>> - *    without modification.
>> - * 2. The name of the author may not be used to endorse or promote products
>> - *    derived from this software without specific prior written permission.
>> - *
> 
> This is not BSD-2-Clause. Ignoring the interior statement about the
> GPL, I think the closest SPDX identifier might be
> https://spdx.org/licenses/BSD-Source-Code.html
> but it doesn't quite match.
> 

BSD-2-Clause but the second clause is the third one on BSD-3-Clause.
Weird...

>> diff --git a/fs/udf/udftime.c b/fs/udf/udftime.c
>> index fce4ad976c8c29..d0fce5348fd3f3 100644
>> --- a/fs/udf/udftime.c
>> +++ b/fs/udf/udftime.c
>> @@ -1,21 +1,4 @@
>> -/* Copyright (C) 1993, 1994, 1995, 1996, 1997 Free Software Foundation, Inc.
>> -   This file is part of the GNU C Library.
>> -   Contributed by Paul Eggert (eggert@...nsun.com).
>> -
>> -   The GNU C Library is free software; you can redistribute it and/or
>> -   modify it under the terms of the GNU Library General Public License as
>> -   published by the Free Software Foundation; either version 2 of the
>> -   License, or (at your option) any later version.
>> -
>> -   The GNU C Library is distributed in the hope that it will be useful,
>> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> -   Library General Public License for more details.
>> -
>> -   You should have received a copy of the GNU Library General Public
>> -   License along with the GNU C Library; see the file COPYING.LIB.  If not,
>> -   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
>> -   Boston, MA 02111-1307, USA.  */
>> +// SPDX-License-Identifier: GPL-2.0-only
> 
> Shouldn't this be
> // SPDX-License-Identifier: LGPL-2.0-or-later ?
> (or are you implicitly using the obscure LGPLv2.x section ... 3 mechanism?)
> 

That's right. I missed the exact notice above when I submitted this
series.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara