netdev - Re: [PATCH] net: ethernet: microchip: vcap: Remove extra semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 13 May 2023 12:06:20 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Anup Sharma <anupnewsmail@...il.com>
CC: Lars Povlsen <lars.povlsen@...rochip.com>, Steen Hegelund
	<Steen.Hegelund@...rochip.com>, Daniel Machon <daniel.machon@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>, "David S. Miller" <davem@...emloft.net>,
	"Eric Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, <linux-arm-kernel@...ts.infradead.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: ethernet: microchip: vcap: Remove extra semicolon

The 05/12/2023 23:18, Anup Sharma wrote:
> [Some people who received this message don't often get email from anupnewsmail@...il.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Remove the extra semicolon at end. Issue identified using
> semicolon.cocci Coccinelle semantic patch.
> 
> drivers/net/ethernet/microchip/vcap/vcap_api.c:1124:3-4: Unneeded semicolon
> drivers/net/ethernet/microchip/vcap/vcap_api.c:1165:3-4: Unneeded semicolon
> drivers/net/ethernet/microchip/vcap/vcap_api.c:1239:3-4: Unneeded semicolon
> drivers/net/ethernet/microchip/vcap/vcap_api.c:1287:3-4: Unneeded semicolon

You have forgotten to add the target tree inside the subject. In this
case, it needs to be net-next. You can do that using:
git format-patch ... --subject-prefix "PATCH net-next" ...

Reviewed-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

> 
> Signed-off-by: Anup Sharma <anupnewsmail@...il.com>
> ---
>  drivers/net/ethernet/microchip/vcap/vcap_api.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c b/drivers/net/ethernet/microchip/vcap/vcap_api.c
> index 5675b0962bc3..a418ad8e8770 100644
> --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c
> +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c
> @@ -1121,7 +1121,7 @@ static void vcap_copy_to_client_actionfield(struct vcap_rule_internal *ri,
>                         vcap_copy_from_w32be(field->data.u128.value, value,
>                                              field_size, width);
>                         break;
> -               };
> +               }
>         } else {
>                 switch (field->ctrl.type) {
>                 case VCAP_FIELD_BIT:
> @@ -1162,7 +1162,7 @@ static void vcap_copy_to_client_actionfield(struct vcap_rule_internal *ri,
>                                                       value,
>                                                       width, field_size);
>                         break;
> -               };
> +               }
>         }
>  }
> 
> @@ -1236,7 +1236,7 @@ static void vcap_copy_to_client_keyfield(struct vcap_rule_internal *ri,
>                         vcap_copy_from_w32be(field->data.u128.mask,  mask,
>                                              field_size, width);
>                         break;
> -               };
> +               }
>         } else {
>                 switch (field->ctrl.type) {
>                 case VCAP_FIELD_BIT:
> @@ -1284,7 +1284,7 @@ static void vcap_copy_to_client_keyfield(struct vcap_rule_internal *ri,
>                                                    value, mask,
>                                                    width, field_size);
>                         break;
> -               };
> +               }
>         }
>  }
> 
> --
> 2.34.1
> 

-- 
/Horatiu