lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202305140248.lh4LUw2j-lkp@intel.com> Date: Sun, 14 May 2023 02:23:50 +0800 From: kernel test robot <lkp@...el.com> To: Harini Katakam <harini.katakam@....com>, andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com, pabeni@...hat.com, vladimir.oltean@....com, wsa+renesas@...g-engineering.com, simon.horman@...igine.com, mkl@...gutronix.de Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, harinikatakamlinux@...il.com, michal.simek@....com, harini.katakam@....com, radhey.shyam.pandey@....com Subject: Re: [PATCH net-next v3 2/3] phy: mscc: Add support for RGMII delay configuration Hi Harini, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Harini-Katakam/phy-mscc-Use-PHY_ID_MATCH_VENDOR-to-minimize-PHY-ID-table/20230511-200935 base: net-next/main patch link: https://lore.kernel.org/r/20230511120808.28646-3-harini.katakam%40amd.com patch subject: [PATCH net-next v3 2/3] phy: mscc: Add support for RGMII delay configuration config: openrisc-randconfig-m041-20230509 (https://download.01.org/0day-ci/archive/20230514/202305140248.lh4LUw2j-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@...el.com> | Link: https://lore.kernel.org/oe-kbuild-all/202305140248.lh4LUw2j-lkp@intel.com/ smatch warnings: drivers/net/phy/mscc/mscc_main.c:1819 vsc85xx_config_init() warn: unsigned 'vsc8531->rx_delay' is never less than zero. drivers/net/phy/mscc/mscc_main.c:1829 vsc85xx_config_init() warn: unsigned 'vsc8531->tx_delay' is never less than zero. vim +1819 drivers/net/phy/mscc/mscc_main.c 1807 1808 static const int vsc8531_internal_delay[] = {200, 800, 1100, 1700, 2000, 2300, 1809 2600, 3400}; 1810 static int vsc85xx_config_init(struct phy_device *phydev) 1811 { 1812 int delay_size = ARRAY_SIZE(vsc8531_internal_delay); 1813 struct vsc8531_private *vsc8531 = phydev->priv; 1814 struct device *dev = &phydev->mdio.dev; 1815 int rc, i, phy_id; 1816 1817 vsc8531->rx_delay = phy_get_internal_delay(phydev, dev, &vsc8531_internal_delay[0], 1818 delay_size, true); > 1819 if (vsc8531->rx_delay < 0) { 1820 if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID || 1821 phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) 1822 vsc8531->rx_delay = RGMII_CLK_DELAY_2_0_NS; 1823 else 1824 vsc8531->rx_delay = RGMII_CLK_DELAY_0_2_NS; 1825 } 1826 1827 vsc8531->tx_delay = phy_get_internal_delay(phydev, dev, &vsc8531_internal_delay[0], 1828 delay_size, false); > 1829 if (vsc8531->tx_delay < 0) { 1830 if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID || 1831 phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) 1832 vsc8531->rx_delay = RGMII_CLK_DELAY_2_0_NS; 1833 else 1834 vsc8531->rx_delay = RGMII_CLK_DELAY_0_2_NS; 1835 } 1836 1837 rc = vsc85xx_default_config(phydev); 1838 if (rc) 1839 return rc; 1840 1841 rc = vsc85xx_mac_if_set(phydev, phydev->interface); 1842 if (rc) 1843 return rc; 1844 1845 rc = vsc85xx_edge_rate_cntl_set(phydev, vsc8531->rate_magic); 1846 if (rc) 1847 return rc; 1848 1849 phy_id = phydev->drv->phy_id & phydev->drv->phy_id_mask; 1850 if (PHY_ID_VSC8531 == phy_id || PHY_ID_VSC8541 == phy_id || 1851 PHY_ID_VSC8530 == phy_id || PHY_ID_VSC8540 == phy_id) { 1852 rc = vsc8531_pre_init_seq_set(phydev); 1853 if (rc) 1854 return rc; 1855 } 1856 1857 rc = vsc85xx_eee_init_seq_set(phydev); 1858 if (rc) 1859 return rc; 1860 1861 for (i = 0; i < vsc8531->nleds; i++) { 1862 rc = vsc85xx_led_cntl_set(phydev, i, vsc8531->leds_mode[i]); 1863 if (rc) 1864 return rc; 1865 } 1866 1867 return 0; 1868 } 1869 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
Powered by blists - more mailing lists