netdev - Re: [PATCH RFC net-next 7/9] net: pcs: xpcs: correct pause resolution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <422f5470-c827-4199-9f87-43120db78e0e@lunn.ch>
Date: Sat, 13 May 2023 20:17:46 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Jose Abreu <Jose.Abreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH RFC net-next 7/9] net: pcs: xpcs: correct pause resolution

> > Hi Russell
> > 
> > I must be missing something. Why not use phylink_resolve_an_pause()?
> 
> Check the next few patches... it eventually gets to using the c73
> helper, entirely eliminating this function.

Yes, i got to that eventually.

What might of helped would of been to include something like:

  This is a staged conversion, so that its easier to bisect down to
  the change that caused anye breakage. The aim is to replace this code
  with the c73 helper.

in the commit message. 

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew