lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230514095133.b4ojnu6y222kzhcb@krzk-bin> Date: Sun, 14 May 2023 11:51:33 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Rudi Heitbaum <rudi@...tbaum.com> Cc: pabeni@...hat.com, alistair@...stair23.me, linux-arm-kernel@...ts.infradead.org, jernej.skrabec@...il.com, robh+dt@...nel.org, davem@...emloft.net, linux-bluetooth@...r.kernel.org, conor+dt@...nel.org, anarsoul@...il.com, devicetree@...r.kernel.org, linux-sunxi@...ts.linux.dev, luiz.dentz@...il.com, johan.hedberg@...il.com, kuba@...nel.org, krzysztof.kozlowski+dt@...aro.org, edumazet@...gle.com, marcel@...tmann.org, wens@...e.org, linux-kernel@...r.kernel.org, samuel@...lland.org, netdev@...r.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: net: realtek-bluetooth: Add RTL8822BS On Sun, 14 May 2023 07:47:29 +0000, Rudi Heitbaum wrote: > Add compatible string for RTL8822BS for existing Realtek Bluetooth > driver. > > Signed-off-by: Rudi Heitbaum <rudi@...tbaum.com> > --- > .../devicetree/bindings/net/realtek-bluetooth.yaml | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed: [{'enum': ['realtek,rtl8821cs-bt']}, {'const': ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt']}] is not of type 'object' ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt'] is not of type 'integer', 'string' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed: [{'enum': ['realtek,rtl8821cs-bt']}, {'const': ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt']}] is not of type 'object' ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt'] is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# Traceback (most recent call last): File "/usr/local/bin/dt-validate", line 167, in <module> sg.check_trees(filename, testtree) ... File "/usr/lib/python3.10/sre_parse.py", line 599, in _parse raise source.error(msg, len(this) + 1 + len(that)) re.error: bad character range s-b at position 18 Note: You even broke the dtschema :) See https://patchwork.ozlabs.org/patch/1781021 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Powered by blists - more mailing lists