netdev - Re: [PATCH v8 0/6] iommu/dma: s390 DMA API conversion and optimized IOTLB flushing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <670b01819f6f875364abaafa4accad9fa92e6177.camel@linux.ibm.com>
Date: Mon, 15 May 2023 11:33:25 +0200
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: Joerg Roedel <joro@...tes.org>, Matthew Rosato <mjrosato@...ux.ibm.com>,
        Will Deacon <will@...nel.org>, Wenjia Zhang <wenjia@...ux.ibm.com>,
        Robin
 Murphy <robin.murphy@....com>, Jason Gunthorpe <jgg@...pe.ca>,
        Gerd Bayer
 <gbayer@...ux.ibm.com>,
        Julian Ruess <julianr@...ux.ibm.com>,
        Pierre Morel
 <pmorel@...ux.ibm.com>,
        Alexandra Winter <wintera@...ux.ibm.com>,
        Heiko
 Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander
 Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger
 <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Suravee
 Suthikulpanit <suravee.suthikulpanit@....com>,
        Hector Martin
 <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig
 <alyssa@...enzweig.io>,
        David Woodhouse <dwmw2@...radead.org>,
        Lu Baolu
 <baolu.lu@...ux.intel.com>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson
 <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Yong Wu
 <yong.wu@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
        Orson Zhai
 <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan
 Zhang <zhang.lyra@...il.com>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec
 <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Thierry
 Reding <thierry.reding@...il.com>,
        Krishna Reddy <vdumpa@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Jonathan Corbet <corbet@....net>, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        iommu@...ts.linux.dev, asahi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-tegra@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v8 0/6] iommu/dma: s390 DMA API conversion and optimized
 IOTLB flushing

On Fri, 2023-05-12 at 07:29 -0700, Christoph Hellwig wrote:
> On Fri, Mar 10, 2023 at 05:07:45PM +0100, Niklas Schnelle wrote:
> > Hi All,
> > 
> > This patch series converts s390's PCI support from its platform specific DMA
> > API implementation in arch/s390/pci/pci_dma.c to the common DMA IOMMU layer.
> > The conversion itself is done in patches 3-4 with patch 2 providing the final
> > necessary IOMMU driver improvement to handle s390's special IOTLB flush
> > out-of-resource indication in virtualized environments. Patches 1-2 may be
> > applied independently. The conversion itself only touches the s390 IOMMU driver
> > and s390 arch code moving over remaining functions from the s390 DMA API
> > implementation. No changes to common code are necessary.
> 
> It looks like this still hasn't made it upstream as of 6.4-rc1.  What's
> holding this series up?
> 

I think with all the IOMMUFD work going on this got starved out of
reviewer resources. I didn't have any open todos but I guess there is
still some review needed around how the IOMMU driver tells the dma-
iommu that it expects IOTLB flushes to be slow requiring a larger
single flush queue. There was also a small conflict with commit
49a22aae7d9c ("iommu: Replace device_lock() with group->mutex") that
prevented this from applying to current upstream so I've just now sent
out a v9 rebased on v6.4-rc2.

Thanks,
Niklas