netdev - Re: [PATCH] net: fec: Refactor: rename `adapter` to `fep`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 15 May 2023 13:58:27 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Csókás Bence <csokas.bence@...lan.hu>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Richard Cochran <richardcochran@...il.com>, qiangqing.zhang@....com,
	kernel@...gutronix.de, Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: fec: Refactor: rename `adapter` to `fep`

On 15.05.2023 13:47:21, Csókás Bence wrote:
> Commit 01b825f reverted a style fix, which renamed
> `struct fec_enet_private *adapter` to `fep` to match
> the rest of the driver.

That description is a bit misleading. In fact commit 01b825f997ac
("Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`"")
reverted a patch that introduced a regression.

As a side effect the problematic patch b353b241f1eb ("net: fec: Use a
spinlock to guard `fep->ptp_clk_on`") renamed struct fec_enet_private
*adapter to fep to match the rest of the driver.

> This commit factors out
> that style fix.
> 
> Signed-off-by: Csókás Bence <csokas.bence@...lan.hu>

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)