netdev - Re: IPV6_VTI config declaration: tristate line is not indented

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZGIme2Vv3NX3ht7s@corigine.com>
Date: Mon, 15 May 2023 14:32:59 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Sundar Nagarajan <sun.nagarajan@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: IPV6_VTI config declaration: tristate line is not indented

On Fri, May 12, 2023 at 02:36:08PM -0700, Sundar Nagarajan wrote:
> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
> index 658bfed1d..c4f6bfd20 100644
> --- a/net/ipv6/Kconfig
> +++ b/net/ipv6/Kconfig
> @@ -152,7 +152,7 @@ config INET6_TUNNEL
>   default n
> 
>  config IPV6_VTI
> -tristate "Virtual (secure) IPv6: tunneling"
> + tristate "Virtual (secure) IPv6: tunneling"
>   select IPV6_TUNNEL
>   select NET_IP_TUNNEL
>   select XFRM

Unfortunately this patch has been white-space mangled: it looks like
tabs have been converted into spaces. So it doesn't apply.

Using a tool such as git send-email or b4 should help avoid this problem.


A few other things.

* The subject should start with [PATCH net-next], where net-next is the
  target tree (as opposed to net, which is for fixes)

  Subject:  [PATCH net-next v2] ...

* The subject should also include a prefix, in this case probably ipv6

  [PATCH net-next v2] ipv6: ...

* Please include a description of the patch, in the body before the patch
  itself.

* Please included a signed off by line.

Oveal, Please take a look at the netdev process document.
Link: https://kernel.org/doc/html/latest/process/maintainer-netdev.html

Likewise for your other patch,
- NET_DSA_SJA1105 config declaration: tristate is not indented
  Link: https://lore.kernel.org/netdev/CALnajPCaJfR+N=vP0R6bXoUwMbopQK6JsJ+pXxS=T6KT5NXswg@mail.gmail.com/

---
pw-bot: cr