netdev - Re: [patch net] devlink: change per-devlink netdev notifier to static one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZGI2R2oTm3/+OM5W@shredder>
Date: Mon, 15 May 2023 16:40:23 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>, netdev@...r.kernel.org,
	kuba@...nel.org, pabeni@...hat.com, davem@...emloft.net,
	edumazet@...gle.com, jacob.e.keller@...el.com, saeedm@...dia.com,
	moshe@...dia.com
Subject: Re: [patch net] devlink: change per-devlink netdev notifier to
 static one

On Mon, May 15, 2023 at 02:37:45PM +0200, Jiri Pirko wrote:
> Mon, May 15, 2023 at 02:05:54PM CEST, idosch@...sch.org wrote:
> >On Mon, May 15, 2023 at 01:35:18PM +0200, Jiri Pirko wrote:
> >> Thanks for the report. From the first sight, don't have a clue what may
> >> be wrong. Debugging.
> >
> >I guess he has CONFIG_NET_NS disabled which turns "__net_initdata" to
> >"__initdata" and frees the notifier block after init. "__net_initdata"
> >is a NOP when CONFIG_NET_NS is enabled.
> >
> >Maybe this will help:
> >
> >diff --git a/net/devlink/core.c b/net/devlink/core.c
> >index 0e58eee44bdb..c23ebabadc52 100644
> >--- a/net/devlink/core.c
> >+++ b/net/devlink/core.c
> >@@ -294,7 +294,7 @@ static struct pernet_operations devlink_pernet_ops __net_initdata = {
> >        .pre_exit = devlink_pernet_pre_exit,
> > };
> > 
> >-static struct notifier_block devlink_port_netdevice_nb __net_initdata = {
> >+static struct notifier_block devlink_port_netdevice_nb = {
> >        .notifier_call = devlink_port_netdevice_event,
> > };
> 
> Yeah I just ended up with the same assumption. That is going to fix it.
> Are you sending the proper patch?

Yes. Will send later today