netdev - Re: [RFC PATCH net-next v6 1/5] net: Add NDOs for hardware timestamp get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP5jrPEFjnHEJi3RHRmQmz3-5RmTXcXLdOp6r4me3z2Z8Fw_BA@mail.gmail.com>
Date: Mon, 15 May 2023 09:36:43 -0600
From: Max Georgiev <glipus@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Vladimir Oltean <vladimir.oltean@....com>, kory.maincent@...tlin.com, 
	netdev@...r.kernel.org, maxime.chevallier@...tlin.com, 
	vadim.fedorenko@...ux.dev, richardcochran@...il.com, 
	gerhard@...leder-embedded.com, liuhangbin@...il.com
Subject: Re: [RFC PATCH net-next v6 1/5] net: Add NDOs for hardware timestamp get/set

On Fri, May 12, 2023 at 11:41 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 11 May 2023 21:22:23 -0600 Max Georgiev wrote:
> > > > +     int                     (*ndo_hwtstamp_get)(struct net_device *dev,
> > > > +                                                 struct kernel_hwtstamp_config *kernel_config,
> > > > +                                                 struct netlink_ext_ack *extack);
> > >
> > > I'm not sure it is necessary to pass an extack to "get". That should
> > > only give a more detailed reason if the driver refuses something.
> >
> > I have to admit I just followed Jakub's guidance adding "extack" to the
> > list of parametres. I'll let Jakub to comment on that.
>
> We can drop it from get, I can't think of any strong use case.

Got it. Will remove the  "extack" parameter from ndo_hwtstamp_get() in the
next revision.