netdev - Re: NET_DSA_SJA1105 config declaration: tristate is not indented

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230515201458.kkbli7fmqtkvb5ju@skbuf>
Date: Mon, 15 May 2023 23:14:58 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Sundar Nagarajan <sun.nagarajan@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: NET_DSA_SJA1105 config declaration: tristate is not indented

Hello,

On Fri, May 12, 2023 at 02:38:44PM -0700, Sundar Nagarajan wrote:
> diff --git a/drivers/net/dsa/sja1105/Kconfig b/drivers/net/dsa/sja1105/Kconfig
> index 1291bba3f..63c9b049f 100644
> --- a/drivers/net/dsa/sja1105/Kconfig
> +++ b/drivers/net/dsa/sja1105/Kconfig
> @@ -1,6 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config NET_DSA_SJA1105
> -tristate "NXP SJA1105 Ethernet switch family support"
> + tristate "NXP SJA1105 Ethernet switch family support"
>   depends on NET_DSA && SPI
>   depends on PTP_1588_CLOCK_OPTIONAL
>   select NET_DSA_TAG_SJA1105

Thank you for your contribution. It has the following problems:

- the context has been mangled by your email client, replacing tabs with
  spaces, so the patch does not apply. I recommend that you use git
  send-email for sending patches.

- patches to netdev must always be formatted against the most recent
  main branches of net.git or net-next.git trees (depending on whether
  they are bug fixes impacting users or just general refactoring/new
  features), and your intention to target one tree or the other must be
  made through the --subject-prefix "PATCH vN net" or "PATCH vN
  net-next" option. Look at other messages in the archive for a hint:
  https://lore.kernel.org/netdev/

- it lacks the "Developer's Certificate of Origin" (the signed-off tag
  generated by "git commit -s").

- it lacks a proper prefix for the commit title indicating the area of
  the code. A better commit title would have been: "net: dsa: sja1105:
  NET_DSA_SJA1105 tristate text is not indented"

- a good commit body (the part after the one-line title) contains:
  1. Context
  2. Problem
  3. Solution
  Yours is empty. The scripts/checkpatch.pl tool should warn about this,
  if you run it.

I would recommend reading a bit what's in the Documentation/process/
folder before resubmitting a v2, I may have missed some finer aspects.