netdev - Re: [PATCH 13/19] can: rcar: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVAy2RKkAesNi1PDJmzWUTQqViho7zGOmZr0ooGD+je_g@mail.gmail.com>
Date: Mon, 15 May 2023 09:53:09 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: u.kleine-koenig@...gutronix.de
Cc: Wolfgang Grandegger <wg@...ndegger.com>, Marc Kleine-Budde <mkl@...gutronix.de>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Vincent Mailhol <mailhol.vincent@...adoo.fr>, Oliver Hartkopp <socketcan@...tkopp.net>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Biju Das <biju.das.jz@...renesas.com>, 
	Simon Horman <simon.horman@...igine.com>, 
	Christophe JAILLET <christophe.jaillet@...adoo.fr>, linux-can@...r.kernel.org, 
	netdev@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH 13/19] can: rcar: Convert to platform remove callback
 returning void

On Fri, May 12, 2023 at 11:27 PM Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove

these drivers

> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds