netdev - RE: [PATCH v2] net: Remove low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY2PR06MB3424294CB196C6CB2C17F12F85799@TY2PR06MB3424.apcprd06.prod.outlook.com>
Date: Tue, 16 May 2023 08:36:54 +0000
From: Angus Chen <angus.chen@...uarmicro.com>
To: Ido Schimmel <idosch@...sch.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "dsahern@...nel.org"
	<dsahern@...nel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Petr Machata
	<petrm@...dia.com>
Subject: RE: [PATCH v2] net: Remove low_thresh in ip defrag



> -----Original Message-----
> From: Ido Schimmel <idosch@...sch.org>
> Sent: Tuesday, May 16, 2023 4:13 PM
> To: Angus Chen <angus.chen@...uarmicro.com>
> Cc: davem@...emloft.net; dsahern@...nel.org; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2] net: Remove low_thresh in ip defrag
> 
> On Mon, May 15, 2023 at 12:06:45PM +0000, Angus Chen wrote:
> > > -----Original Message-----
> > > From: Ido Schimmel <idosch@...sch.org>
> > > Sent: Monday, May 15, 2023 7:03 PM
> > > To: Angus Chen <angus.chen@...uarmicro.com>
> > > Cc: davem@...emloft.net; dsahern@...nel.org; edumazet@...gle.com;
> > > kuba@...nel.org; pabeni@...hat.com; netdev@...r.kernel.org;
> > > linux-kernel@...r.kernel.org
> > > Subject: Re: [PATCH v2] net: Remove low_thresh in ip defrag
> > >
> > > On Fri, May 12, 2023 at 09:01:52AM +0800, Angus Chen wrote:
> > > > As low_thresh has no work in fragment reassembles,del it.
> > > > And Mark it deprecated in sysctl Document.
> > > >
> > > > Signed-off-by: Angus Chen <angus.chen@...uarmicro.com>
> > >
> > > Getting the following traces with this patch when creating a netns:
> > Sorry for test miss because I tested it in card and didn't test it with multi net.
> > Should I create a pernet struct for it?
> > It may looks too complicated.
> 
> Sorry but I don't understand the motivation behind this patch. IIUC, the
> sysctl is deprecated and has no use in the kernel, yet it cannot be
> removed because user space may rely on it being present. If so, what is
> the significance of the code changes in this patch? Why not just update
> the documentation?
Thank you .
One tester asked me why low_thresh is not work well in our product,
So I want to send a little patch to mark the code.
I will just modify low_thresh to low_thresh_unused to simplify this cleanup.