netdev - Re: [PATCH net-next 00/19] can: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230516-sharply-sulphuric-2c99e8c1cbda-mkl@pengutronix.de>
Date: Tue, 16 May 2023 10:54:06 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Simon Horman <simon.horman@...igine.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Claudiu Beznea <claudiu.beznea@...rochip.com>,
	Dario Binacchi <dario.binacchi@...rulasolutions.com>,
	Minghao Chi <chi.minghao@....com.cn>,
	Zhang Changzhong <zhangchangzhong@...wei.com>,
	Wei Fang <wei.fang@....com>, Rob Herring <robh@...nel.org>,
	Pavel Pisa <pisa@....felk.cvut.cz>,
	Ondrej Ille <ondrej.ille@...il.com>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	Haibo Chen <haibo.chen@....com>,
	Oliver Hartkopp <socketcan@...tkopp.net>,
	Yang Yingliang <yangyingliang@...wei.com>,
	Chandrasekar Ramakrishnan <rcsekar@...sung.com>,
	Chris Packham <chris.packham@...iedtelesis.co.nz>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Wolfram Sang <wsa@...nel.org>, Mark Brown <broonie@...nel.org>,
	Dongliang Mu <dzm91@...t.edu.cn>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Biju Das <biju.das.jz@...renesas.com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Chen-Yu Tsai <wens@...e.org>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Samuel Holland <samuel@...lland.org>,
	Appana Durga Kedareswara rao <appana.durga.rao@...inx.com>,
	Michal Simek <michal.simek@....com>, linux-can@...r.kernel.org,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	kernel@...gutronix.de, linux-sunxi@...ts.linux.dev,
	Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>
Subject: Re: [PATCH net-next 00/19] can: Convert to platform remove callback
 returning void

On 16.05.2023 10:45:23, Simon Horman wrote:
> On Tue, May 16, 2023 at 09:31:04AM +0200, Simon Horman wrote:
> > On Fri, May 12, 2023 at 11:27:06PM +0200, Uwe Kleine-König wrote:
> > > Hello,
> > > 
> > > this series convers the drivers below drivers/net/can to the
> > > .remove_new() callback of struct platform_driver(). The motivation is to
> > > make the remove callback less prone for errors and wrong assumptions.
> > > See commit 5c5a7680e67b ("platform: Provide a remove callback that
> > > returns no value") for a more detailed rationale.
> > > 
> > > All drivers already returned zero unconditionally in their
> > > .remove() callback, so converting them to .remove_new() is trivial.
> > 
> > Hi Uwe,
> > 
> > I like these changes and they all look good to me.
> > However, I have a question, perhaps more directed at the netdev
> > maintainers than yourself.
> > 
> > In principle patch-sets for netdev should not include more than 15 patches.
> > It's unclear to me if, on the basis of that, this patchset should
> > be split up. Or if, f.e. given the simple nature of the patches,
> > an exception applies in this case. Or something else.
> > 
> > I have no fixed opinion on this.
> > But I feel that the question should be asked.
> > 
> > Link: https://kernel.org/doc/html/v6.1/process/maintainer-netdev.html
> > 
> > ...
> 
> I now realise this series is for can.
> Which I assume means the guidance above doesn't apply.
> 
> Sorry for the noise.

That's still a good point, because sooner or later Uwe will probably
also convert the platform drivers to Driver/Network/Ethernet.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)