netdev - Re: [PATCH 2/2] rust: add socket support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01b36031-944b-4bf3-b089-f90bb421457c@lunn.ch>
Date: Tue, 16 May 2023 14:07:18 +0200
From: Andrew Lunn <andrew@...n.ch>
To: FUJITA Tomonori <tomo@...bit.dev>
Cc: rust-for-linux@...r.kernel.org, netdev@...r.kernel.org,
	linux-crypto@...r.kernel.org, fujita.tomonori@...il.com
Subject: Re: [PATCH 2/2] rust: add socket support

On Tue, May 16, 2023 at 05:43:21AM +0000, FUJITA Tomonori wrote:
> On Mon, 15 May 2023 16:14:56 +0200
> Andrew Lunn <andrew@...n.ch> wrote:
> 
> > On Mon, May 15, 2023 at 04:34:28AM +0000, FUJITA Tomonori wrote:
> >> From: FUJITA Tomonori <fujita.tomonori@...il.com>
> >> 
> >> minimum abstraction for networking.
> > 
> >> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>
> >> ---
> >>  rust/bindings/bindings_helper.h |   3 +
> >>  rust/kernel/lib.rs              |   2 +
> >>  rust/kernel/net.rs              | 174 ++++++++++++++++++++++++++++++++
> > 
> > The full networking API is huge. So trying to put it all into net.rs
> > is unlikely to work in the long run. Maybe it would be better to name
> > this file based on the tiny little bit of the network API you are
> > writing an abstraction for?
> 
> Yeah, in the long run. I tried the simplest but if the maintainers
> prefer that approach as the first step, I'll update the patch. how
> about rust/net/socket.rs ?

That is better. But probably Eric or one of the other core maintainers
should comment. I also put kern into the name to try to make it clear
that this is not the BSD Socket kAPI, but the kernel internal API for
sockets. I don't know how important this distinction is.

	 Andrew