lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <442ce443-a1fb-1cfa-e3df-14927307f9c7@intel.com>
Date: Mon, 15 May 2023 19:53:04 -0700
From: "Tantilov, Emil S" <emil.s.tantilov@...el.com>
To: Stephen Hemminger <stephen@...workplumber.org>
CC: <intel-wired-lan@...ts.osuosl.org>, <shannon.nelson@....com>,
	<simon.horman@...igine.com>, <leon@...nel.org>, <decot@...gle.com>,
	<willemb@...gle.com>, Phani Burra <phani.r.burra@...el.com>,
	<jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <netdev@...r.kernel.org>, Alan Brady
	<alan.brady@...el.com>, Madhu Chittim <madhu.chittim@...el.com>, "Shailendra
 Bhatnagar" <shailendra.bhatnagar@...el.com>, Pavan Kumar Linga
	<pavan.kumar.linga@...el.com>
Subject: Re: [PATCH iwl-next v5 02/15] idpf: add module register and probe
 functionality



On 5/13/2023 6:45 PM, Stephen Hemminger wrote:
> On Sat, 13 May 2023 15:56:57 -0700
> Emil Tantilov <emil.s.tantilov@...el.com> wrote:
> 
>> +struct idpf_hw {
>> +	void __iomem *hw_addr;
>> +	resource_size_t hw_addr_len;
>> +
>> +	void *back;
>> +};
> 
> It is safer to use a typed pointer rather than untyped (void *) for
> the back pointer. This could prevent bugs.

Right. Will convert to typed.

Thanks,
Emil

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ