netdev - Re: [PATCH v4 20/41] net: handle HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 16 May 2023 16:48:02 +0100 (BST)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Niklas Schnelle <schnelle@...ux.ibm.com>
cc: Arnd Bergmann <arnd@...db.de>, "David S. Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
    Paolo Abeni <pabeni@...hat.com>, 
    Michael Grzeschik <m.grzeschik@...gutronix.de>, 
    Wolfgang Grandegger <wg@...ndegger.com>, 
    Marc Kleine-Budde <mkl@...gutronix.de>, 
    Jesse Brandeburg <jesse.brandeburg@...el.com>, 
    Tony Nguyen <anthony.l.nguyen@...el.com>, 
    Ralf Baechle <ralf@...ux-mips.org>, 
    Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    Bjorn Helgaas <bhelgaas@...gle.com>, 
    Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
    Mauro Carvalho Chehab <mchehab@...nel.org>, 
    Alan Stern <stern@...land.harvard.edu>, 
    "Rafael J. Wysocki" <rafael@...nel.org>, 
    Geert Uytterhoeven <geert@...ux-m68k.org>, 
    Paul Walmsley <paul.walmsley@...ive.com>, 
    Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
    linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, 
    linux-pci@...r.kernel.org, Arnd Bergmann <arnd@...nel.org>, 
    netdev@...r.kernel.org, linux-can@...r.kernel.org, 
    intel-wired-lan@...ts.osuosl.org, linux-hams@...r.kernel.org
Subject: Re: [PATCH v4 20/41] net: handle HAS_IOPORT dependencies

On Tue, 16 May 2023, Niklas Schnelle wrote:

> diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c
> index 1fef8a9b1a0f..0fbbb7286008 100644
> --- a/drivers/net/fddi/defxx.c
> +++ b/drivers/net/fddi/defxx.c
> @@ -254,7 +254,7 @@ static const char version[] =
>  #define DFX_BUS_TC(dev) 0
>  #endif
>  
> -#if defined(CONFIG_EISA) || defined(CONFIG_PCI)
> +#ifdef CONFIG_HAS_IOPORT
>  #define dfx_use_mmio bp->mmio
>  #else
>  #define dfx_use_mmio true

 For this part:

Acked-by: Maciej W. Rozycki <macro@...am.me.uk>

  Maciej