netdev - Re: [PATCH net v2 4/4] Documentation: net/mlx5: Wrap notes in admonition blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874joccet2.fsf@meer.lwn.net>
Date: Tue, 16 May 2023 12:27:21 -0600
From: Jonathan Corbet <corbet@....net>
To: Bagas Sanjaya <bagasdotme@...il.com>, Linux Networking
 <netdev@...r.kernel.org>, Remote Direct Memory Access Kernel Subsystem
 <linux-rdma@...r.kernel.org>, Linux Documentation
 <linux-doc@...r.kernel.org>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Bagas Sanjaya <bagasdotme@...il.com>, Gal Pressman
 <gal@...dia.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>, Maher Sanalla
 <msanalla@...dia.com>, Moshe Shemesh <moshe@...dia.com>, Tariq Toukan
 <tariqt@...dia.com>, Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH net v2 4/4] Documentation: net/mlx5: Wrap notes in
 admonition blocks

Bagas Sanjaya <bagasdotme@...il.com> writes:

> Wrap note paragraphs in note:: directive as it better fit for the
> purpose of noting devlink commands.
>
> Fixes: f2d51e579359b7 ("net/mlx5: Separate mlx5 driver documentation into multiple pages")
> Fixes: cf14af140a5ad0 ("net/mlx5e: Add vnic devlink health reporter to representors")
> Reviewed-by: Leon Romanovsky <leonro@...dia.com>
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---
>  .../ethernet/mellanox/mlx5/devlink.rst             | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

So these changes seem harmless, but the Fixes: tags seem completely
inappropriate here.  This is format tweaking, not a bug fix.

Thanks,

jon