netdev - Re: [PATCH net v2 2/4] Documentation: net/mlx5: Use bullet and definition lists for vnic counters description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGPW9BZajS3q33ki@DEN-LT-70577>
Date: Tue, 16 May 2023 19:18:13 +0000
From: <Daniel.Machon@...rochip.com>
To: <bagasdotme@...il.com>
CC: <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<saeedm@...dia.com>, <leon@...nel.org>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<corbet@....net>, <gal@...dia.com>, <rrameshbabu@...dia.com>,
	<msanalla@...dia.com>, <moshe@...dia.com>, <tariqt@...dia.com>,
	<leonro@...dia.com>
Subject: Re: [PATCH net v2 2/4] Documentation: net/mlx5: Use bullet and
 definition lists for vnic counters description

>  Description of the vnic counters:
> -total_q_under_processor_handle: number of queues in an error state due to
> -an async error or errored command.
> -send_queue_priority_update_flow: number of QP/SQ priority/SL update
> -events.
> -cq_overrun: number of times CQ entered an error state due to an
> -overflow.
> -async_eq_overrun: number of times an EQ mapped to async events was
> -overrun.
> -comp_eq_overrun: number of times an EQ mapped to completion events was
> -overrun.
> -quota_exceeded_command: number of commands issued and failed due to quota
> -exceeded.
> -invalid_command: number of commands issued and failed dues to any reason
> -other than quota exceeded.
> -nic_receive_steering_discard: number of packets that completed RX flow
> -steering but were discarded due to a mismatch in flow table.
> +
> +- total_q_under_processor_handle
> +        number of queues in an error state due to
> +        an async error or errored command.
> +- send_queue_priority_update_flow
> +        number of QP/SQ priority/SL update events.
> +- cq_overrun
> +        number of times CQ entered an error state due to an overflow.
> +- async_eq_overrun
> +        number of times an EQ mapped to async events was overrun.
> +        comp_eq_overrun number of times an EQ mapped to completion events was
> +        overrun.
> +- quota_exceeded_command
> +        number of commands issued and failed due to quota exceeded.
> +- invalid_command
> +        number of commands issued and failed dues to any reason other than quota
> +        exceeded.

Hi Bagas,

nit: I think 'dues' should be 'due' here. Might as well get that in
when touching the code anyway.

Other than that:

Reviewed-by: Daniel Machon <daniel.machon@...rochip.com>

> +- nic_receive_steering_discard
> +        number of packets that completed RX flow
> +        steering but were discarded due to a mismatch in flow table.