netdev - Re: [PATCH net-next V2 1/2] virtio-net: convert rx mode setting to use workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230516123635.58a20bb0@kernel.org>
Date: Tue, 16 May 2023 12:36:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jason Wang <jasowang@...hat.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com,
 virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
 maxime.coquelin@...hat.com, alvaro.karsz@...id-run.com,
 eperezma@...hat.com, xuanzhuo@...ux.alibaba.com, david.marchand@...hat.com,
 netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next V2 1/2] virtio-net: convert rx mode setting to
 use workqueue

On Tue, 16 May 2023 12:17:50 +0800 Jason Wang wrote:
> > It's not reliable for other drivers but has been reliable for virtio.
> > I worry some software relied on this.  
> 
> It's probably fine since some device like vhost doesn't support this
> at all and we manage to survive for several years.
> 
> > You are making good points though ... could we get some
> > maintainer's feedback on this?  
> 
> That would be helpful. Jakub, any input on this?

AFAIU the question is whether .ndo_set_rx_mode needs to be reliable 
and instantaneous?  I haven't heard any complaints for it not being
immediate, and most 10G+ NICs do the config via a workqueue.

I even have an "intern task" to implement a workqueue in the core,
for this to save the boilerplate code in the drivers.