netdev - Re: [PATCH net-next 1/2] net: Keep sk->sk_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 May 2023 13:46:55 +0800
From: Oliver Sang <oliver.sang@...el.com>
To: Shakeel Butt <shakeelb@...gle.com>
CC: "Zhang, Cathy" <cathy.zhang@...el.com>, Yin Fengwei
	<fengwei.yin@...el.com>, Feng Tang <feng.tang@...el.com>, Eric Dumazet
	<edumazet@...gle.com>, Linux MM <linux-mm@...ck.org>, Cgroups
	<cgroups@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Srinivas, Suresh" <suresh.srinivas@...el.com>, "Chen, Tim C"
	<tim.c.chen@...el.com>, "You, Lizhen" <lizhen.you@...el.com>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, <philip.li@...el.com>, <yujie.liu@...el.com>,
	<oliver.sang@...el.com>
Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper
 size

hi Shakeel,

On Mon, May 15, 2023 at 12:50:31PM -0700, Shakeel Butt wrote:
> +Feng, Yin and Oliver
> 
> >
> > > Thanks a lot Cathy for testing. Do you see any performance improvement for
> > > the memcached benchmark with the patch?
> >
> > Yep, absolutely :- ) RPS (with/without patch) = +1.74
> 
> Thanks a lot Cathy.
> 
> Feng/Yin/Oliver, can you please test the patch at [1] with other
> workloads used by the test robot? Basically I wanted to know if it has
> any positive or negative impact on other perf benchmarks.

is it possible for you to resend patch with Signed-off-by?
without it, test robot will regard the patch as informal, then it cannot feed
into auto test process.
and could you tell us the base of this patch? it will help us apply it
correctly.

on the other hand, due to resource restraint, we normally cannot support
this type of on-demand test upon a single patch, patch set, or a branch.
instead, we try to merge them into so-called hourly-kernels, then distribute
tests and auto-bisects to various platforms.
after we applying your patch and merging it to hourly-kernels sccussfully,
if it really causes some performance changes, the test robot could spot out
this patch as 'fbc' and we will send report to you. this could happen within
several weeks after applying.
but due to the complexity of whole process (also limited resourse, such like
we cannot run all tests on all platforms), we cannot guanrantee capture all
possible performance impacts of this patch. and it's hard for us to provide
a big picture like what's the general performance impact of this patch.
this maybe is not exactly what you want. is it ok for you?

> 
> [1] https://lore.kernel.org/all/20230512171702.923725-1-shakeelb@google.com/
> 
> Thanks in advance.