netdev - Re: [PATCH v4 5/7] pinctrl: ingenic: relax return value check for IRQ get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 May 2023 09:49:58 +0200
From: Paul Cercueil <paul@...pouillou.net>
To: Matti Vaittinen <mazziesaccount@...il.com>, Matti Vaittinen
	 <matti.vaittinen@...rohmeurope.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Daniel Scally
 <djrscally@...il.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
 Sakari Ailus <sakari.ailus@...ux.intel.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>,
 Andreas Klinger <ak@...klinger.de>, Marcin Wojtas <mw@...ihalf.com>,
 Russell King <linux@...linux.org.uk>,  "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jonathan
 Neuschäfer <j.neuschaefer@....net>,  Linus Walleij
 <linus.walleij@...aro.org>, Wolfram Sang <wsa@...nel.org>, Akhil R
 <akhilrajeev@...dia.com>,  linux-acpi@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux-iio@...r.kernel.org,
 netdev@...r.kernel.org, openbmc@...ts.ozlabs.org, 
 linux-gpio@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v4 5/7] pinctrl: ingenic: relax return value check for
 IRQ get

Hi Matti,

Le mardi 16 mai 2023 à 10:13 +0300, Matti Vaittinen a écrit :
> fwnode_irq_get[_byname]() were changed to not return 0 anymore.
> 
> Drop check for return value 0.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> 
> ---
> 
> The first patch of the series changes the fwnode_irq_get() so this
> depends
> on the first patch of the series and should not be applied alone.
> ---
>  drivers/pinctrl/pinctrl-ingenic.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index 2f220a47b749..86e71ad703a5 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -4201,8 +4201,6 @@ static int __init ingenic_gpio_probe(struct
> ingenic_pinctrl *jzpc,
>         err = fwnode_irq_get(fwnode, 0);
>         if (err < 0)
>                 return err;
> -       if (!err)
> -               return -EINVAL;
>         jzgc->irq = err;
>  
>         girq = &jzgc->gc.irq;
> -- 
> 2.40.1
> 
>