netdev - Re: [PATCH net-next v5 1/8] net: wangxun: libwx add tx offload functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGM7JvIckFCGcH9F@corigine.com>
Date: Tue, 16 May 2023 10:13:26 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Mengyuan Lou <mengyuanlou@...-swift.com>
Cc: netdev@...r.kernel.org, jiawenwu@...stnetic.com
Subject: Re: [PATCH net-next v5 1/8] net: wangxun: libwx add tx offload
 functions

On Mon, May 15, 2023 at 08:08:22PM +0800, Mengyuan Lou wrote:
> Add tx offload functions for wx_xmit_frame_ring which
> includes wx_encode_tx_desc_ptype, wx_tso and wx_tx_csum.
> which supports ngbe and txgbe to implement tx offload
> function.
> 
> Signed-off-by: Mengyuan Lou <mengyuanlou@...-swift.com>

...

> @@ -326,6 +324,33 @@
>  
>  #define WX_RXD_ERR_RXE               BIT(29) /* Any MAC Error */
>  
> +/**
> + * receive packet type
> + * PTYPE:8 = TUN:2 + PKT:2 + TYP:4
> + **/

Hi,

The comment above looks like a kernel-doc but is not.

$ ./scripts/kernel-doc -none drivers/net/ethernet/wangxun/libwx/wx_type.h
drivers/net/ethernet/wangxun/libwx/wx_type.h:328: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

...