netdev - Re: [PATCH v2 7/9] wifi: ath11k: Use RMW accessors for changing LNKCTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wn17kyli.fsf@kernel.org>
Date: Wed, 17 May 2023 14:04:57 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: linux-pci@...r.kernel.org,  Bjorn Helgaas <bhelgaas@...gle.com>,
  Lorenzo Pieralisi <lorenzo.pieralisi@....com>,  Rob Herring
 <robh@...nel.org>,  Krzysztof Wilczyński <kw@...ux.com>,
  Emmanuel Grumbach <emmanuel.grumbach@...el.com>,  "Rafael J . Wysocki"
 <rafael@...nel.org>,  Heiner Kallweit <hkallweit1@...il.com>,  Lukas
 Wunner <lukas@...ner.de>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Carl Huang <cjhuang@...eaurora.org>,
  ath11k@...ts.infradead.org,  linux-wireless@...r.kernel.org,
  netdev@...r.kernel.org,  linux-kernel@...r.kernel.org,  Dean Luick
 <dean.luick@...nelisnetworks.com>,  Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>,  stable@...r.kernel.org
Subject: Re: [PATCH v2 7/9] wifi: ath11k: Use RMW accessors for changing LNKCTL

Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> writes:

> Don't assume that only the driver would be accessing LNKCTL. ASPM
> policy changes can trigger write to LNKCTL outside of driver's control.
>
> Use RMW capability accessors which do proper locking to avoid losing
> concurrent updates to the register value. On restore, clear the ASPMC
> field properly.
>
> Fixes: e9603f4bdcc0 ("ath11k: pci: disable ASPM L0sLs before downloading firmware")
> Suggested-by: Lukas Wunner <lukas@...ner.de>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> Cc: stable@...r.kernel.org

Acked-by: Kalle Valo <kvalo@...nel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches