netdev - Re: [PATCH v2 6/9] net/mlx5: Use RMW accessors for changing LNKCTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fdd518db-a759-b520-fb1e-d697d6f08682@nvidia.com>
Date: Wed, 17 May 2023 14:18:58 +0300
From: Moshe Shemesh <moshe@...dia.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	<linux-pci@...r.kernel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, "Lorenzo
 Pieralisi" <lorenzo.pieralisi@....com>, Rob Herring <robh@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>, Emmanuel Grumbach
	<emmanuel.grumbach@...el.com>, "Rafael J . Wysocki" <rafael@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>, Lukas Wunner <lukas@...ner.de>,
	"Saeed Mahameed" <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	"Jakub Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Moshe
 Shemesh <moshe@...lanox.com>, <netdev@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: Dean Luick <dean.luick@...nelisnetworks.com>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>, <stable@...r.kernel.org>
Subject: Re: [PATCH v2 6/9] net/mlx5: Use RMW accessors for changing LNKCTL


On 5/17/2023 1:52 PM, Ilpo Järvinen wrote:
> Don't assume that only the driver would be accessing LNKCTL of the
> upstream bridge. ASPM policy changes can trigger write to LNKCTL
> outside of driver's control.
>
> Use RMW capability accessors which do proper locking to avoid losing
> concurrent updates to the register value.
>
> Fixes: eabe8e5e88f5 ("net/mlx5: Handle sync reset now event")
> Suggested-by: Lukas Wunner<lukas@...ner.de>
> Signed-off-by: Ilpo Järvinen<ilpo.jarvinen@...ux.intel.com>
> Cc:stable@...r.kernel.org
Reviewed-by: Moshe Shemesh <moshe@...dia.com>

Thanks!