netdev - Re: [PATCH v4 0/7] fix fwnode_irq_get[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 17 May 2023 16:09:37 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Daniel Scally <djrscally@...il.com>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Andreas Klinger <ak@...klinger.de>,
 Marcin Wojtas <mw@...ihalf.com>, Russell King <linux@...linux.org.uk>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Jonathan Neuschäfer <j.neuschaefer@....net>,
 Paul Cercueil <paul@...pouillou.net>, Wolfram Sang <wsa@...nel.org>,
 Akhil R <akhilrajeev@...dia.com>, linux-acpi@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 netdev@...r.kernel.org, openbmc@...ts.ozlabs.org,
 linux-gpio@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v4 0/7] fix fwnode_irq_get[_byname()] returnvalue

On 5/17/23 15:43, Linus Walleij wrote:
> On Tue, May 16, 2023 at 9:12 AM Matti Vaittinen
> <mazziesaccount@...il.com> wrote:
> 
>> The fwnode_irq_get() and the fwnode_irq_get_byname() may have returned
>> zero if mapping the IRQ fails. This contradicts the
>> fwnode_irq_get_byname() documentation. Furthermore, returning zero or
>> errno on error is unepected and can easily lead to problems
>> like:
> 
> Also, zero is not really a valid IRQ, it means NO_IRQ:
> https://lwn.net/Articles/470820/
> 
> I'll apply the pinctrl patches.

Thanks Linus. I guess you noticed but please wait until the patch 1/7 
gets in as the pinctrl patches won't do "the right thing" without it. 
(Just ensuring we are on a same page ;) )

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~