netdev - Re: [PATCH net] net/mlx5e: do as little as possible in napi poll when budget is 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230516190232.71b1ba28@kernel.org>
Date: Tue, 16 May 2023 19:02:32 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com,
 saeedm@...dia.com, leon@...nel.org, brouer@...hat.com, tariqt@...lanox.com
Subject: Re: [PATCH net] net/mlx5e: do as little as possible in napi poll
 when budget is 0

On Mon, 15 May 2023 18:39:20 +0200 Eric Dumazet wrote:
> > +       /* budget=0 means we may be in IRQ context, do as little as possible */
> > +       if (unlikely(!budget)) {
> > +               /* no work done, can't be asked to re-enable IRQs */
> > +               WARN_ON_ONCE(napi_complete_done(napi, work_done));  
> 
> This is not clear why you call napi_complete_done() here ?
> 
> Note the fine doc  ( https://www.kernel.org/doc/html/next/networking/napi.html )
> says:
> 
> <quote>If the budget is 0 napi_complete_done() should never be called.</quote>

fair point, I was trying to be conservative because I think it would
have gotten called before