lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230516202059.09aab4d0@kernel.org>
Date: Tue, 16 May 2023 20:20:59 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Horman <simon.horman@...igine.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, wuych <yunchuan@...china.com>,
 dchickles@...vell.com, sburla@...vell.com, fmanlunas@...vell.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: liquidio: lio_core: Remove unnecessary
 (void*) conversions

On Mon, 15 May 2023 22:19:31 +0200 Simon Horman wrote:
> On Mon, May 15, 2023 at 05:56:21PM +0300, Dan Carpenter wrote:
> > On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote:  
> > > Networking code needs to be in Reverse Christmas Tree order.  Longest
> > > lines first.  This code wasn't really in Reverse Christmas Tree order
> > > to begine with but now it's more obvious.  
> > 
> > Oh, duh.  This obviously can't be reversed because it depends on the
> > first declaration.  Sorry for the noise.  
> 
> FWIIW, I think the preferred approach for such cases is to
> separate the declaration and initialisation. Something like:
> 
> 	struct octeon_device *oct = droq->oct_dev;
> 	struct octeon_device_priv *oct_priv;
> 
> 	oct_priv = oct->priv;

I don't think these changes are worth bothering with at all, TBH.

Powered by blists - more mailing lists