lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <168430465407.24096.14761627656437604341.kvalo@kernel.org> Date: Wed, 17 May 2023 06:24:17 +0000 (UTC) From: Kalle Valo <kvalo@...nel.org> To: Arnd Bergmann <arnd@...nel.org> Cc: Arnd Bergmann <arnd@...db.de>, Michael Büsch <m@...s.ch>, kernel test robot <lkp@...el.com>, Simon Horman <simon.horman@...igine.com>, Larry Finger <Larry.Finger@...inger.net>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev Subject: Re: [PATCH] [v2] wifi: b43: fix incorrect __packed annotation Arnd Bergmann <arnd@...nel.org> wrote: > From: Arnd Bergmann <arnd@...db.de> > > clang warns about an unpacked structure inside of a packed one: > > drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct b43_iv' is less aligned than 'union (unnamed union at /home/arnd/arm-soc/drivers/net/wireless/broadcom/b43/b43.h:651:2)' and is usually due to 'struct b43_iv' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] > > The problem here is that the anonymous union has the default alignment > from its members, apparently because the original author mixed up the > placement of the __packed attribute by placing it next to the struct > member rather than the union definition. As the struct itself is > also marked as __packed, there is no need to mark its members, so just > move the annotation to the inner type instead. > > As Michael noted, the same problem is present in b43legacy, so > change both at the same time. > > Acked-by: Michael Büsch <m@...s.ch> > Reported-by: kernel test robot <lkp@...el.com> > Reviewed-by: Simon Horman <simon.horman@...igine.com> > Tested-by: Larry Finger <Larry.Finger@...inger.net> > Link: https://lore.kernel.org/oe-kbuild-all/202305160749.ay1HAoyP-lkp@intel.com/ > Signed-off-by: Arnd Bergmann <arnd@...db.de> Patch applied to wireless.git, thanks. 212457ccbd60 wifi: b43: fix incorrect __packed annotation -- https://patchwork.kernel.org/project/linux-wireless/patch/20230516183442.536589-1-arnd@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists