netdev - Re: [PATCH] can: ctucanfd: Fix an error handling path in ctucan_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230517-lugged-wreckage-65f6d28379ac-mkl@pengutronix.de>
Date: Wed, 17 May 2023 09:05:43 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Pavel Pisa <pisa@....felk.cvut.cz>, Ondrej Ille <ondrej.ille@...il.com>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Martin Jerabek <martin.jerabek01@...il.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-can@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] can: ctucanfd: Fix an error handling path in
 ctucan_probe_common()

On 16.05.2023 18:47:17, Christophe JAILLET wrote:
> Le 15/05/2023 à 22:51, Marc Kleine-Budde a écrit :
> > On 15.05.2023 22:36:28, Christophe JAILLET wrote:
> > > If register_candev() fails, a previous netif_napi_add() needs to be undone.
> > > Add the missing netif_napi_del() in the error handling path.
> > 
> > What about this path:
> > free_candev(ndev) -> free_netdev() -> netif_napi_del()
> > 
> > | https://elixir.bootlin.com/linux/v6.3.2/source/net/core/dev.c#L10714
> > 
> > Marc
> > 
> 
> Ok, thanks for the review,
> 
> so in fact this is the netif_napi_del() call in ctucan_platform_remove()
> that can be removed instead.
> 
> Harmless, but would be more consistent.
> I'll send a patch for that.

Make it so!

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)