lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <63f12ee5-bd7d-a734-af98-e99196d84441@blackwall.org> Date: Wed, 17 May 2023 10:33:03 +0300 From: Nikolay Aleksandrov <razor@...ckwall.org> To: Arnd Bergmann <arnd@...nel.org>, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Cc: Arnd Bergmann <arnd@...db.de>, Roopa Prabhu <roopa@...dia.com>, bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/4] bridge: always declare tunnel functions On 16/05/2023 22:45, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@...db.de> > > When CONFIG_BRIDGE_VLAN_FILTERING is disabled, two functions are still > defined but have no prototype or caller. This causes a W=1 warning for > the missing prototypes: > > net/bridge/br_netlink_tunnel.c:29:6: error: no previous prototype for 'vlan_tunid_inrange' [-Werror=missing-prototypes] > net/bridge/br_netlink_tunnel.c:199:5: error: no previous prototype for 'br_vlan_tunnel_info' [-Werror=missing-prototypes] > > The functions are already contitional on CONFIG_BRIDGE_VLAN_FILTERING, > and I coulnd't easily figure out the right set of #ifdefs, so just > move the declarations out of the #ifdef to avoid the warning, > at a small cost in code size over a more elaborate fix. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > net/bridge/br_private_tunnel.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > This should be for -net. Fixes: 188c67dd1906 ("net: bridge: vlan options: add support for tunnel id dumping") Fixes: 569da0822808 ("net: bridge: vlan options: add support for tunnel mapping set/del") Acked-by: Nikolay Aleksandrov <razor@...ckwall.org> Thanks, Nik
Powered by blists - more mailing lists