netdev - Re: [PATCH] can: ctucanfd: Remove a useless netif_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202305181949.ywS3ECIq-lkp@intel.com>
Date: Thu, 18 May 2023 20:18:12 +0800
From: kernel test robot <lkp@...el.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Pavel Pisa <pisa@....felk.cvut.cz>,
	Ondrej Ille <ondrej.ille@...il.com>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	linux-can@...r.kernel.org
Subject: Re: [PATCH] can: ctucanfd: Remove a useless netif_napi_del() call

Hi Christophe,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkl-can-next/testing]
[also build test WARNING on linus/master v6.4-rc2 next-20230518]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christophe-JAILLET/can-ctucanfd-Remove-a-useless-netif_napi_del-call/20230518-151217
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
patch link:    https://lore.kernel.org/r/58500052a6740806e8af199ece45e97cb5eeb1b8.1684393811.git.christophe.jaillet%40wanadoo.fr
patch subject: [PATCH] can: ctucanfd: Remove a useless netif_napi_del() call
config: x86_64-allmodconfig
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/aaed91df00cf16ff7783fa535c29228072d41554
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Christophe-JAILLET/can-ctucanfd-Remove-a-useless-netif_napi_del-call/20230518-151217
        git checkout aaed91df00cf16ff7783fa535c29228072d41554
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305181949.ywS3ECIq-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/can/ctucanfd/ctucanfd_platform.c: In function 'ctucan_platform_remove':
>> drivers/net/can/ctucanfd/ctucanfd_platform.c:91:29: warning: unused variable 'priv' [-Wunused-variable]
      91 |         struct ctucan_priv *priv = netdev_priv(ndev);
         |                             ^~~~


vim +/priv +91 drivers/net/can/ctucanfd/ctucanfd_platform.c

e8f0c23a2415fa Pavel Pisa       2022-03-22  81  
e8f0c23a2415fa Pavel Pisa       2022-03-22  82  /**
e8f0c23a2415fa Pavel Pisa       2022-03-22  83   * ctucan_platform_remove - Unregister the device after releasing the resources
e8f0c23a2415fa Pavel Pisa       2022-03-22  84   * @pdev:	Handle to the platform device structure
e8f0c23a2415fa Pavel Pisa       2022-03-22  85   *
e8f0c23a2415fa Pavel Pisa       2022-03-22  86   * This function frees all the resources allocated to the device.
e8f0c23a2415fa Pavel Pisa       2022-03-22  87   */
45413bf759193d Uwe Kleine-König 2023-05-12  88  static void ctucan_platform_remove(struct platform_device *pdev)
e8f0c23a2415fa Pavel Pisa       2022-03-22  89  {
e8f0c23a2415fa Pavel Pisa       2022-03-22  90  	struct net_device *ndev = platform_get_drvdata(pdev);
e8f0c23a2415fa Pavel Pisa       2022-03-22 @91  	struct ctucan_priv *priv = netdev_priv(ndev);
e8f0c23a2415fa Pavel Pisa       2022-03-22  92  
e8f0c23a2415fa Pavel Pisa       2022-03-22  93  	netdev_dbg(ndev, "ctucan_remove");
e8f0c23a2415fa Pavel Pisa       2022-03-22  94  
e8f0c23a2415fa Pavel Pisa       2022-03-22  95  	unregister_candev(ndev);
e8f0c23a2415fa Pavel Pisa       2022-03-22  96  	pm_runtime_disable(&pdev->dev);
e8f0c23a2415fa Pavel Pisa       2022-03-22  97  	free_candev(ndev);
e8f0c23a2415fa Pavel Pisa       2022-03-22  98  }
e8f0c23a2415fa Pavel Pisa       2022-03-22  99  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "config" of type "text/plain" (295539 bytes)