netdev - Re: [PATCH iproute2-next v3] ip-link: add support for nolocalbypass in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZGYoTIYd71a463vP@shredder>
Date: Thu, 18 May 2023 16:29:48 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Vladimir Nikishkin <vladimir@...ishkin.pw>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com,
	eng.alaamohamedsoliman.am@...il.com, gnault@...hat.com,
	razor@...ckwall.org, idosch@...dia.com, liuhangbin@...il.com,
	eyal.birger@...il.com, jtoppins@...hat.com
Subject: Re: [PATCH iproute2-next v3] ip-link: add support for nolocalbypass
 in vxlan

On Thu, May 18, 2023 at 12:00:30PM +0800, Vladimir Nikishkin wrote:
> Add userspace support for the [no]localbypass vxlan netlink
> attribute. With localbypass on (default), the vxlan driver processes
> the packets destined to the local machine by itself, bypassing the
> userspace nework stack. With nolocalbypass the packets are always
> forwarded to the userspace network stack, so userspace programs,
> such as tcpdump have a chance to process them.
> 
> Signed-off-by: Vladimir Nikishkin <vladimir@...ishkin.pw>
> ---
> v2=>v3: 1. replace fputs with print_string                                                                                                     2. fix 77 char line length                                                                                                             3. fix typos and improve man page                                                                                                      4. reformat strcmp usage                                                                                                        this patch matches commit 69474a8a5837be63f13c6f60a7d622b98ed5c539                                                                     in the main tree.                                                                                                                      

The changelog is corrupted

[...]

> +.sp
> +.RB [ no ] localbypass
> +- if FDB destination is local, with nolocalbypass set, forward encapsulated
> +packets to the userspace network stack. If there is a userspace process
> +listening for these packets, it will have a chance to process them. If
> +localbypass is active (default), bypass the userspace network stack and

s/userspace/kernel/

> +inject the packets ingit to the target VXLAN device, assuming one exists.

s/ingit/into/ ?