lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZGZIKkKZ45T6tq8U@corigine.com> Date: Thu, 18 May 2023 17:45:46 +0200 From: Simon Horman <simon.horman@...igine.com> To: Jakub Kicinski <kuba@...nel.org> Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com, borisp@...dia.com, john.fastabend@...il.com, tariqt@...dia.com, Shai Amiram <samiram@...dia.com> Subject: Re: [PATCH net 7/7] tls: rx: strp: don't use GFP_KERNEL in softirq context On Tue, May 16, 2023 at 06:50:42PM -0700, Jakub Kicinski wrote: > When receive buffer is small, or the TCP rx queue looks too > complicated to bother using it directly - we allocate a new > skb and copy data into it. > > We already use sk->sk_allocation... but nothing actually > sets it to GFP_ATOMIC on the ->sk_data_ready() path. > > Users of HW offload are far more likely to experience problems > due to scheduling while atomic. "Copy mode" is very rarely > triggered with SW crypto. > > Fixes: 84c61fe1a75b ("tls: rx: do not use the standard strparser") > Tested-by: Shai Amiram <samiram@...dia.com> > Signed-off-by: Jakub Kicinski <kuba@...nel.org> Reviewed-by: Simon Horman <simon.horman@...igine.com>
Powered by blists - more mailing lists