netdev - Re: [PATCH net 2/3] ipv6: exthdrs: avoid potential NULL deref in ipv6_srh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGZbFD4Xhui5mjd1@corigine.com>
Date: Thu, 18 May 2023 19:06:28 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alexander Aring <alex.aring@...il.com>,
	David Lebrun <david.lebrun@...ouvain.be>, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH net 2/3] ipv6: exthdrs: avoid potential NULL deref in
 ipv6_srh_rcv()

On Wed, May 17, 2023 at 09:31:17PM +0000, Eric Dumazet wrote:
> There is some chance __in6_dev_get() returns NULL, we should
> not crash if that happens.
> 
> ipv6_srh_rcv() caller (ipv6_rthdr_rcv()) correctly deals with
> a NULL idev, we can use the same idea.
> 
> Same problem was later added in ipv6_rpl_srh_rcv(),
> this is handled in a separate patch to ease stable backports.
> 
> Fixes: 1ababeba4a21 ("ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: David Lebrun <david.lebrun@...ouvain.be>
> Cc: Alexander Aring <alex.aring@...il.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>