lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1947d38c30b18829a5c122025c52847e.paul@paul-moore.com> Date: Thu, 18 May 2023 13:12:00 -0400 From: Paul Moore <paul@...l-moore.com> To: Matthieu Baerts <matthieu.baerts@...sares.net>, James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, Stephen Smalley <stephen.smalley.work@...il.com>, Eric Paris <eparis@...isplace.org> Cc: Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Ondrej Mosnacek <omosnace@...hat.com>, mptcp@...ts.linux.dev, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-security-module@...r.kernel.org, selinux@...r.kernel.org, Matthieu Baerts <matthieu.baerts@...sares.net> Subject: Re: [PATCH v2 2/2] selinux: Implement mptcp_add_subflow hook On Apr 20, 2023 Matthieu Baerts <matthieu.baerts@...sares.net> wrote: > > Newly added subflows should inherit the LSM label from the associated > MPTCP socket regardless of the current context. > > This patch implements the above copying sid and class from the MPTCP > socket context, deleting the existing subflow label, if any, and then > re-creating the correct one. > > The new helper reuses the selinux_netlbl_sk_security_free() function, > and the latter can end-up being called multiple times with the same > argument; we additionally need to make it idempotent. > > Signed-off-by: Paolo Abeni <pabeni@...hat.com> > Acked-by: Matthieu Baerts <matthieu.baerts@...sares.net> > Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net> > --- > v2: > - Address Paul's comments: > - use "MPTCP socket" instead of "msk" in the commit message > - "updated" context instead of "current" one in the comment > --- > security/selinux/hooks.c | 16 ++++++++++++++++ > security/selinux/netlabel.c | 8 ++++++-- > 2 files changed, 22 insertions(+), 2 deletions(-) Also merged into selinux/next, thanks again. -- paul-moore.com
Powered by blists - more mailing lists