lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <d574c978-c2b8-f2e0-abc5-19899b4fefe6@alu.unizg.hr> Date: Thu, 18 May 2023 20:50:16 +0200 From: Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr> To: Johannes Berg <johannes@...solutions.net>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Leon Romanovsky <leonro@...dia.com> Subject: Re: [PATCH v5 1/1] wifi: mac80211: fortify the spinlock against deadlock by interrupt On 5/17/23 23:34, Johannes Berg wrote: >> >> Fixes: 4444bc2116ae ("wifi: mac80211: Proper mark iTXQs for resumption") >> Link: https://lore.kernel.org/all/1f58a0d1-d2b9-d851-73c3-93fcc607501c@alu.unizg.hr/ >> Reported-by: Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr> >> Link: https://lore.kernel.org/all/cdc80531-f25f-6f9d-b15f-25e16130b53a@alu.unizg.hr/ >> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr> >> Reviewed-by: Leon Romanovsky <leonro@...dia.com> >> --- >> > > You really should say what you changed, but anyway, it's too late - I > applied a previous version yesterday. Yes. Sorry, I was following Andy's advice to resend, at the wrong assumption that the system ate the patch after three weeks of inactivity. :-/ The difference is really in the mailbox containing the patch, but git somehow ate that, too. Beginner's errors. :-( --- v4 -> v5: - Some cleanup, keeping the longer stacktrace as requested v3 -> v4: - Added whole lockdep trace as advised. - Trimmed irrelevant line prefix. v2 -> v3: - Fix the Fixes: tag as advised. - Change the net: to wifi: to comply with the original patch that is being fixed. v1 -> v2: - Minor rewording and clarification. - Cc:-ed people that replied to the original bug report (forgotten in v1 by omission). net/mac80211/tx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Rest assured, the code did not change. It is a rather obvious fix to the interrupt caused deadlock. > Also, I suspect you just collected the reviewed-by tag here, which > really you shouldn't be doing a resend for. This is correct, plus cosmetic removal of Cc:s as advised. Sorry for confusion, I am really having a great time with the Intel Linux team and I am currently updating my homework on Wi-Fi. Provided that there will be more use of me for the wireless. But I can always justify anything used in multimedia or graphic rendering as my field of research. Well, almost anything :-) Best regards, Mirsad
Powered by blists - more mailing lists