lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230518133627.72747418@kernel.org> Date: Thu, 18 May 2023 13:36:27 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Alexander Lobakin <aleksander.lobakin@...el.com> Cc: Jesper Dangaard Brouer <hawk@...nel.org>, Larysa Zaremba <larysa.zaremba@...el.com>, <netdev@...r.kernel.org>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, <linux-kernel@...r.kernel.org>, "Christoph Hellwig" <hch@....de>, Eric Dumazet <edumazet@...gle.com>, Michal Kubiak <michal.kubiak@...el.com>, <intel-wired-lan@...ts.osuosl.org>, Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, Magnus Karlsson <magnus.karlsson@...el.com> Subject: Re: [Intel-wired-lan] [PATCH net-next 07/11] net: page_pool: add DMA-sync-for-CPU inline helpers On Thu, 18 May 2023 17:41:52 +0200 Alexander Lobakin wrote: > > Or maybe we can do both? I think that separating types, defines and > > simple wrappers from helpers should be considered good code hygiene. > > I'll definitely take a look, I also like the idea of minimalistic and > lightweight headers. > page_pool.h and page_pool_drv.h? :D What I've been doing lately is split like this: include/net/something.h (simply includes all other headers) include/net/something/types.h (structs, defines, enums) include/net/something/functions.h (inlines and function declarations) If that's reasonable -- we should put the helpers under include/net/page_pool/functions.h ?
Powered by blists - more mailing lists