netdev - Re: [PATCH net-next] i40e: add PHY debug register dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6b96409-5b08-4df5-b4fd-6f1db8ada690@lunn.ch>
Date: Fri, 19 May 2023 20:35:04 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Radoslaw Tyl <radoslawx.tyl@...el.com>,
	Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next] i40e: add PHY debug register dump

On Fri, May 19, 2023 at 10:02:08AM -0700, Tony Nguyen wrote:
> From: Radoslaw Tyl <radoslawx.tyl@...el.com>
> 
> Implement ethtool register dump for some PHY registers in order to
> assist field debugging of link issues.
> 
> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@...el.com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Why not just implement phy_mii_ioctl()? You don't need custom ethtool
registers if these are PHY registers. You can use the well defined
IOCTL interface for reading PHY registers.

      Andrew