netdev - Re: [PATCH v13 5/7] io-uring: add sqpoll support for napi busy poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 May 2023 12:35:34 +0800
From: kernel test robot <lkp@...el.com>
To: Stefan Roesch <shr@...kernel.io>, io-uring@...r.kernel.org,
	kernel-team@...com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, shr@...kernel.io,
	axboe@...nel.dk, ammarfaizi2@...weeb.org, netdev@...r.kernel.org,
	kuba@...nel.org, olivier@...llion01.com
Subject: Re: [PATCH v13 5/7] io-uring: add sqpoll support for napi busy poll

Hi Stefan,

kernel test robot noticed the following build errors:

[auto build test ERROR on d2b7fa6174bc4260e496cbf84375c73636914641]

url:    https://github.com/intel-lab-lkp/linux/commits/Stefan-Roesch/net-split-off-__napi_busy_poll-from-napi_busy_poll/20230519-054117
base:   d2b7fa6174bc4260e496cbf84375c73636914641
patch link:    https://lore.kernel.org/r/20230518211751.3492982-6-shr%40devkernel.io
patch subject: [PATCH v13 5/7] io-uring: add sqpoll support for napi busy poll
config: mips-pic32mzda_defconfig
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project b0fb98227c90adf2536c9ad644a74d5e92961111)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mipsel-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/8d324fedc325505406b6ea808d5d7a7cacb321a5
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Stefan-Roesch/net-split-off-__napi_busy_poll-from-napi_busy_poll/20230519-054117
        git checkout 8d324fedc325505406b6ea808d5d7a7cacb321a5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305191242.JLAg91z4-lkp@intel.com/

All errors (new ones prefixed by >>):

>> io_uring/sqpoll.c:198:11: error: expected expression
                           ret += io_napi_sqpoll_busy_poll(ctx);
                                  ^
   io_uring/napi.h:81:39: note: expanded from macro 'io_napi_sqpoll_busy_poll'
   #define io_napi_sqpoll_busy_poll(ctx) do {} while (0)
                                         ^
   1 error generated.


vim +198 io_uring/sqpoll.c

   167	
   168	static int __io_sq_thread(struct io_ring_ctx *ctx, bool cap_entries)
   169	{
   170		unsigned int to_submit;
   171		int ret = 0;
   172	
   173		to_submit = io_sqring_entries(ctx);
   174		/* if we're handling multiple rings, cap submit size for fairness */
   175		if (cap_entries && to_submit > IORING_SQPOLL_CAP_ENTRIES_VALUE)
   176			to_submit = IORING_SQPOLL_CAP_ENTRIES_VALUE;
   177	
   178		if (!wq_list_empty(&ctx->iopoll_list) || to_submit) {
   179			const struct cred *creds = NULL;
   180	
   181			if (ctx->sq_creds != current_cred())
   182				creds = override_creds(ctx->sq_creds);
   183	
   184			mutex_lock(&ctx->uring_lock);
   185			if (!wq_list_empty(&ctx->iopoll_list))
   186				io_do_iopoll(ctx, true);
   187	
   188			/*
   189			 * Don't submit if refs are dying, good for io_uring_register(),
   190			 * but also it is relied upon by io_ring_exit_work()
   191			 */
   192			if (to_submit && likely(!percpu_ref_is_dying(&ctx->refs)) &&
   193			    !(ctx->flags & IORING_SETUP_R_DISABLED))
   194				ret = io_submit_sqes(ctx, to_submit);
   195			mutex_unlock(&ctx->uring_lock);
   196	
   197			if (io_napi(ctx))
 > 198				ret += io_napi_sqpoll_busy_poll(ctx);
   199	
   200			if (to_submit && wq_has_sleeper(&ctx->sqo_sq_wait))
   201				wake_up(&ctx->sqo_sq_wait);
   202			if (creds)
   203				revert_creds(creds);
   204		}
   205	
   206		return ret;
   207	}
   208	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "config" of type "text/plain" (48928 bytes)