lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <aed51991-7f4f-b8c5-e899-48e8f23075fb@bootlin.com> Date: Mon, 22 May 2023 14:26:50 +0200 From: Alexis Lothoré <alexis.lothore@...tlin.com> To: Andrew Lunn <andrew@...n.ch> Cc: "Russell King (Oracle)" <linux@...linux.org.uk>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com, paul.arola@...us.com, scott.roberts@...us.com, Marek Behún <kabel@...nel.org> Subject: Re: [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: enable support for 88E6361 switch Hello Andrew, On 5/22/23 14:19, Andrew Lunn wrote: >>> Not exactly related to this patch, but please do not rely on this "max >>> speed mode" - please always ensure that you specify the phy-mode and >>> fixed-link settings for CPU and DSA ports in firmware. Thanks. >> >> I would like to make sure to fully understand your point: >> - when telling so specify phy-mode and fixed-link in firmware, you mean >> device-tree, right ? >> - when checking for code and execution flow, I observe that port_max_speed is >> always called and its output is always used to configure shared ports mode in >> mv88e6xxx driver. Are you telling that eventually, the whole mv88e6xxx driver >> should stop relying on port_max_speed_mode for shared ports ? > > Yes, the concept of port_max_speed_mode causes problems for PHYLINK, > and we want to remove it. Russell and i have been updating DT > descriptions adding fixed-link and phy-mode properties to all > mv88e6xxx systems so that it is not needed. Either at the end of this > cycle, or the beginning of the next we will change the code to > actually enforce this. Understood, thanks for clarification > > Andrew -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Powered by blists - more mailing lists